[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 11 Mar 2020 16:34:37 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@xxxxxxxxxx; spf=Pass smtp.mailfrom=roger.pau@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Wed, 11 Mar 2020 15:34:53 +0000
  • Ironport-sdr: MddIhxuNTX0gHLJSy4EF1CA1foSxzfD4tIB1vDXK11S19kRWjErH9U9Ud+WvnpC+f5awWtFyTI m1q/YCS99pZyozCQ6q/0k6hr0t5a1RWPmWtzlWLJ+VNHlZCpZjtIg5FzVNqg5VZqahkT3qD2X8 a8KcKodM5oTgjoFmaYkZIvKkz0UUaACozRgAJkAi2D6VuH9zezqiUXsg/q31PusYeyZikzD03M TGt/jQZW5gLap+CyWA0D4PTyzWZ0BMkfQwdeREhg8dK2J5xEDHhbWE/Zfi/nCJOeQ1o3WAWkIf K9k=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote:
> On 28.02.2020 13:07, Roger Pau Monne wrote:
> > Current usage of the per-CPU scratch cpumask is dangerous since
> > there's no way to figure out if the mask is already being used except
> > for manual code inspection of all the callers and possible call paths.
> > 
> > This is unsafe and not reliable, so introduce a minimal get/put
> > infrastructure to prevent nested usage of the scratch mask and usage
> > in interrupt context.
> > 
> > Move the declaration of scratch_cpumask to smp.c in order to place the
> > declaration and the accessors as close as possible.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Ping? This seems to have the required RB, but hasn't been committed.

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.