Re: [Xen-devel] [XEN PATCH v3 13/23] xen/build: include include/config/auto.conf in main Makefile

[Jan Beulich <jbeulich@xxxxxxxx>]

On 10.03.2020 18:10, Anthony PERARD wrote:
> On Wed, Mar 04, 2020 at 03:29:55PM +0100, Jan Beulich wrote:
>> On 26.02.2020 12:33, Anthony PERARD wrote:
>>> +# The actual configuration files used during the build are stored in
>>> +# include/generated/ and include/config/. Update them if .config is newer 
>>> than
>>> +# include/config/auto.conf (which mirrors .config).
>>> +#
>>> +# This exploits the 'multi-target pattern rule' trick.
>>> +# The syncconfig should be executed only once to make all the targets.
>>> +include/config/%.conf include/config/%.conf.cmd: $(KCONFIG_CONFIG)
>>> +   $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) 
>>> SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" syncconfig
>>
>> ... this are almost identical, pretty long lines. Can this be macroized,
>> please, with the actual make goal as parameter?
> 
> Sound good, would the following be fine?
> 
> kconfig = -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) 
> SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)"
> config:
>     $(MAKE) $(kconfig) $@
> 
> I will put that new `kconfig' macro in Kbuild.include, along the
> shorthand for clean.

Looks okay at the first glance.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel