Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

[Jan Beulich <jbeulich@xxxxxxxx>]

On 26.02.2020 12:33, Anthony PERARD wrote:
> This is part of upgrading our build system and import more of Linux's
> one.
> 
> In Linux, subdir-y in Makefiles is only used to descend into
> subdirectory when there are no object to build, Xen doesn't have that
> and all subdir have object to be included in the final binary.
> 
> To allow the new syntax, the "obj-y" and "subdir-*" calculation in
> Rules.mk is changed and partially imported from Linux's Kbuild.
> 
> The command used to modify the Makefile was:
>     sed -i -r 's#^subdir-(.*)#obj-\1/#;' **/Makefile
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> 
> Notes:
>     v3:
>     - no more tabs
>     - reshuffle variable, and remove __subdir-y
> 
>  xen/Rules.mk                         | 19 ++++++++-----------
>  xen/arch/arm/Makefile                | 14 +++++++-------
>  xen/arch/arm/arm32/Makefile          |  2 +-
>  xen/arch/arm/arm64/Makefile          |  2 +-

Julien, Stefano - any chance of getting an ack here?

>  xen/arch/x86/Makefile                | 18 +++++++++---------
>  xen/arch/x86/acpi/Makefile           |  2 +-
>  xen/arch/x86/cpu/Makefile            |  4 ++--
>  xen/arch/x86/guest/Makefile          |  4 ++--
>  xen/arch/x86/hvm/Makefile            |  6 +++---
>  xen/arch/x86/mm/Makefile             |  4 ++--
>  xen/arch/x86/x86_64/Makefile         |  2 +-
>  xen/common/Makefile                  | 10 +++++-----
>  xen/drivers/Makefile                 | 14 +++++++-------
>  xen/drivers/acpi/Makefile            |  6 +++---
>  xen/drivers/passthrough/Makefile     |  8 ++++----
>  xen/drivers/passthrough/vtd/Makefile |  2 +-

Kevin, how about this one?

>  xen/lib/Makefile                     |  2 +-
>  xen/xsm/Makefile                     |  2 +-
>  xen/xsm/flask/Makefile               |  2 +-

Daniel, how about these?

I guess the latter two are small enough to skip further waiting for
acks once the Arm one would be in place. Getting this patch in
would unblock a fair part of the remainder of this series.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel