Re: [Xen-devel] [PATCH] libxenstat: fixed Makefile for building python-bindings

[Wei Liu <wl@xxxxxxx>]

Hi Jonas

Thanks for this patch.

On Mon, Mar 02, 2020 at 06:53:38PM +0100, jonas.licht@xxxxxxxxxxxxxxxxx wrote:
> Fixes the libxenstat Makefile to determine the correct paths
> of python includes when building python-bindings.
> Also replaces the -lxenstat linking to correct object files
> and use the libdir variable for installing.
> 
> Signed-off-by: Jonas Licht <jonas.licht@xxxxxxxxxxxxxxxxx>
> ---
>  tools/xenstat/libxenstat/Makefile | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/xenstat/libxenstat/Makefile
> b/tools/xenstat/libxenstat/Makefile
> index 03cb212e3b..4a02d2e563 100644
> --- a/tools/xenstat/libxenstat/Makefile
> +++ b/tools/xenstat/libxenstat/Makefile
> @@ -114,18 +114,17 @@ $(BINDINGS): $(SHLIB) $(SHLIB_LINKS) src/xenstat.h
>  SWIG_FLAGS=-module xenstat -Isrc
> 
>  # Python bindings
> -PYTHON_VERSION=$(PYTHON:python%=%)
> -PYTHON_FLAGS=-I/usr/include/python$(PYTHON_VERSION)
> -lpython$(PYTHON_VERSION)
> +PYTHON_FLAGS=`$(PYTHON) -c 'import distutils.sysconfig; print("-I" +

A better approach would be to use python-config here.

> distutils.sysconfig.get_python_inc(True) + " " +
> distutils.sysconfig.get_config_var("BLDLIBRARY"))'`
>  $(PYMOD): $(PYSRC)
>  $(PYSRC): bindings/swig/xenstat.i
>         swig -python $(SWIG_FLAGS) -outdir $(@D) -o $(PYSRC) $<
> 
>  $(PYLIB): $(PYSRC)
> -       $(CC) $(CFLAGS) $(LDFLAGS) $(PYTHON_FLAGS) $(SHLIB_LDFLAGS)
> -lxenstat -o $@ $< $(APPEND_LDFLAGS)
> +       $(CC) $(CFLAGS) $(LDFLAGS) $(PYTHON_FLAGS) $(SHLIB_LDFLAGS) -o $@ $<
> $(SHLIB) $(LDLIBS-y) $(APPEND_LDFLAGS)
> 
>  python-bindings: $(PYLIB) $(PYMOD)
> 
> -pythonlibdir=$(prefix)/lib/python$(PYTHON_VERSION)/site-packages
> +pythonlibdir=`$(PYTHON) -c 'import distutils.sysconfig;

And here.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel