[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/5] IOMMU: iommu_intremap is x86-only

On 02/03/2020 10:07, Jan Beulich wrote:
On 28.02.2020 21:16, Andrew Cooper wrote:
On 28/02/2020 12:26, Jan Beulich wrote:
Provide a #define for other cases; it didn't seem worthwhile to me to
introduce an IOMMU_INTREMAP Kconfig option at this point.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1299,6 +1299,8 @@ boolean (e.g. `iommu=no`) can override t
      generation of IOMMUs only supported DMA remapping, and Interrupt Remapping
      appeared in the second generation.
+ This option is not valid on Arm.

The longevity of this comment would be greater if it were phrased as "is
only valid on x86", especially given the RFC RISCV series on list.

How do we know how intremap is going to work on future ports?

We don't know. But, for a reviewer, it is going to be much easier to notice a command line option is going to be used as the patch would modify a caller.

So I agree with Andrew that we want to say "only valid on x86".


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.