Re: [Xen-devel] [PATCH] x86/sysctl: Don't return cpu policy data for compiled-out support

[Jan Beulich <jbeulich@xxxxxxxx>]

On 26.02.2020 10:58, Andrew Cooper wrote:
> On 26/02/2020 09:32, Jan Beulich wrote:
>> On 25.02.2020 18:31, Andrew Cooper wrote:
>>> Policy objects aren't tiny, and the derivation logic isn't trivial.  We are
>>> about to increase the number of policy objects, so take this opportunity to
>>> drop logic and storage space based on CONFIG_{PV,HVM}.
>> It doesn't look as if you were dropping either logic or storage space. With
>> this aspect taken care of (by adjusting wording, or by clarification of what
>> is meant) ...
>>
>>> Start by
> 
> That is this is here to signify.

How about s/take this/will have the/ in the sentence further up then?
To me, "Start by" in no way indicates that really there aren't any
savings yet. Might be my non-native English understanding of this
phrase, of course.

> No logic or storage space can be dropped until some #ifdef-ary is
> sprinkled around cpuid.c and msr.c, but I can't do any of that while
> there are unguarded external references to the objects.

Of course.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel