Re: [Xen-devel] [PATCH] kimage: Allow load/exec for images with KEXEC_TYPE_LIVE_UPDATE

[Jan Beulich <jbeulich@xxxxxxxx>]

On 07.02.2020 10:00, Varad Gautam wrote:
> Do not -EINVAL on loading/execing an image if kexec type is
> KEXEC_TYPE_LIVE_UPDATE.
> 
> Signed-off-by: Varad Gautam <vrd@xxxxxxxxx>
> CC: David Woodhouse <dwmw@xxxxxxxxxxxx>

Please Cc maintainers on patches.

> --- a/xen/common/kimage.c
> +++ b/xen/common/kimage.c
> @@ -421,6 +421,7 @@ struct page_info *kimage_alloc_control_page(struct 
> kexec_image *image,
>      switch ( image->type )
>      {
>      case KEXEC_TYPE_DEFAULT:
> +    case KEXEC_TYPE_LIVE_UPDATE:
>          pages = kimage_alloc_normal_control_page(image, memflags);
>          break;
>      case KEXEC_TYPE_CRASH:
> @@ -775,6 +776,7 @@ static int kimage_load_segment(struct kexec_image *image, 
> xen_kexec_segment_t *s
>          switch ( image->type )
>          {
>          case KEXEC_TYPE_DEFAULT:
> +        case KEXEC_TYPE_LIVE_UPDATE:
>              result = kimage_load_normal_segment(image, segment);
>              break;
>          case KEXEC_TYPE_CRASH:
> @@ -803,6 +805,7 @@ int kimage_alloc(struct kexec_image **rimage, uint8_t 
> type, uint16_t arch,
>      switch( type )
>      {
>      case KEXEC_TYPE_DEFAULT:
> +    case KEXEC_TYPE_LIVE_UPDATE:
>          result = kimage_normal_alloc(rimage, entry_maddr, nr_segments, 
> segment);
>          break;
>      case KEXEC_TYPE_CRASH:

You don't mention any prereq patches, and I can't see any
definition of KEXEC_TYPE_LIVE_UPDATE in the public headers.
IOW I can't see how this patch would be able to not break
the build on current staging. Please clarify.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel