Re: [Xen-devel] [PATCH v7 01/10] x86/hypervisor: make hypervisor_ap_setup return an error code

[Wei Liu <wl@xxxxxxx>]

On Tue, Feb 04, 2020 at 03:36:55PM +0000, Wei Liu wrote:
> We want to be able to handle AP setup error in the upper layer.
> 
> For Xen, remove all panic() and BUG_ON() in init_evtchn and
> map_vcpuinfo. Only panic/BUG_ON when Xen can't fail gracefully.
> 
> Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>
> ---

BTW I discover an issue: init_evtchn sets HVM_PARAM_CALLBACK_IRQ every
time it is called. That's unnecessary for APs. Perhaps it would be best
to break that function into two, one for setting HVM_PARAM_CALLBACK_IRQ,
the other for allocating and setting callback. BSP needs to call both
while APs only needs to call the latter.

This is out of scope for this series, but it is something to consider in
the future.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel