Re: [Xen-devel] [PATCH v2 2/4] x86/vvmx: fix VM_EXIT_ACK_INTR_ON_EXIT handling

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Feb 04, 2020 at 01:39:44AM +0000, Tian, Kevin wrote:
> > From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> > Sent: Monday, February 3, 2020 8:19 PM
> > 
> > When VM_EXIT_ACK_INTR_ON_EXIT is set in the vmexit control vmcs
> 
> set->cleared
> 
> > register the bit 31 of VM_EXIT_INTR_INFO must be 0, in order to denote
> > that the field doesn't contain any interrupt information. This is not
> > currently acknowledged as the field always get filled with valid
> > interrupt information, regardless of whether VM_EXIT_ACK_INTR_ON_EXIT
> > is set.
> > 
> > Fix this and only fill VM_EXIT_INTR_INFO when VM_EXIT_ACK_INTR_ON_EXIT
> > is not set. Note that this requires one minor change in
> 
> not set -> set
> 
> > nvmx_update_apicv in order to obtain the interrupt information from
> > the internal state rather than the nested vmcs register.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> with above fixed, 

Ouch yes, I've inverted the conditions. Thanks for noticing.

> 
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

To whoever picks this patch for committing: let me know if you would
like me to resend with the commit log fixed.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel