Re: [Xen-devel] [PATCH v3 5/9] libs: add libxenhypfs

[Wei Liu <wl@xxxxxxx>]

On Tue, Jan 21, 2020 at 09:43:26AM +0100, Juergen Gross wrote:
> Add the new library libxenhypfs for access to the hypervisor filesystem.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

I've only skimmed read it. The code looks sensible.

One minor comment.

> diff --git a/tools/libs/hypfs/xenhypfs.pc.in b/tools/libs/hypfs/xenhypfs.pc.in
> new file mode 100644
> index 0000000000..9cb968f0db
> --- /dev/null
> +++ b/tools/libs/hypfs/xenhypfs.pc.in
> @@ -0,0 +1,10 @@
> +prefix=@@prefix@@
> +includedir=@@incdir@@
> +libdir=@@libdir@@
> +
> +Name: Xenhypfs
> +Description: The Xenhypfs library for Xen hypervisor
> +Version: @@version@@
> +Cflags: -I${includedir} @@cflagslocal@@
> +Libs: @@libsflag@@${libdir} -lxenhypfs
> +Requires.private: xentoolcore,xentoollog,xencall

Need to list libz here?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel