Re: [Xen-devel] [PATCH] tools/xenstore: don't apply write limiting for privileged domain

[Wei Liu <wl@xxxxxxx>]

On Fri, Jan 31, 2020 at 03:25:57PM +0100, Juergen Gross wrote:
> Xenstore write limiting should not be applied to dom0. Unfortunately
> write limiting is disabled only for connections via sockets. When
> running in a stubdom Xenstore will apply write limiting to dom0, too.
> Change that by testing for the domain to be privileged as well.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Acked-by: Wei Liu <wl@xxxxxxx>

> ---
>  tools/xenstore/xenstored_domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/xenstore/xenstored_domain.c 
> b/tools/xenstore/xenstored_domain.c
> index 1a83097952..c7c6c574df 100644
> --- a/tools/xenstore/xenstored_domain.c
> +++ b/tools/xenstore/xenstored_domain.c
> @@ -918,8 +918,8 @@ void wrl_apply_debit_actual(struct domain *domain)
>  {
>       struct wrl_timestampt now;
>  
> -     if (!domain)
> -             /* sockets escape the write rate limit */
> +     if (!domain || !domid_is_unprivileged(domain->domid))
> +             /* sockets and dom0 escape the write rate limit */
>               return;
>  
>       wrl_gettime_now(&now);
> -- 
> 2.16.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel