Re: [Xen-devel] [PATCH v4 4/7] libxl: add infrastructure to track and query 'recent' domids

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Jan 22, 2020 at 02:44:43PM +0000, Paul Durrant wrote:
> A domid is considered recent if the domain it represents was destroyed
> less than a specified number of seconds ago. The number can be set using
> the environment variable LIBXL_DOMID_REUSE_TIMEOUT. If the variable does
> not exist then a default value of 60s is used.

Could you rewrite that part of the commit message? By reading it, it
sounds to me like LIBXL_DOMID_REUSE_TIMEOUT is a configuration variable
that a toolstack may want to set. Whereas the comment in
libxl_internal.h indicates that it's for debuging.  Having env var for
debugging sounds good, but having env var as configuration doesn't.

> +/*
> + * Maximum number of seconds after desctruction then a domid remains
> + * 'recent'. Recent domids are not allowed to be re-used. This can be
> + * overidden, for debugging purposes, by the environment variable of the
> + * same name.
> + */
> +#define LIBXL_DOMID_REUSE_TIMEOUT 60

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel