[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] iommu/arm: Don't allow the same micro-TLB to be shared between domains
- To: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Thu, 30 Jan 2020 15:20:21 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1PEtnFN0UZ2bf17pKjUkH2sdddNDULeAXhhLWLit86o=; b=e/N+Uskrb/gGXJwl6xf2h2k7qREBb/Me04RFlNEueP8d5S2a5sB9XNocgLU80UlvMOqpa8CBaPM5TxKAWRtJQmRJ4+hvZm+N0VWietAQMkWcvNEKZUcs3fK0vbzhf1wQo4jsQJmQBPuip5XrOV7Kx6bSVsT7Nj+yxG3RKv7eZKQpY/181w+Pm8hjAWZpqLUDUX68hgPN4EDJqF0hBMCWOKFc3QUYi7LiisBE5lxB06uAuDV2mUJFTnGMTp/4/TTtkE36AqyICS366beRf/SGsuiwZRLEyns8DFtGPvKwSbirQZlQY3e3/W+22dUfPGGXH2brAgqSRM1illVU4TDcmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JKZX9mfYTDUxfBRK+Rx+vYuphRMf/SWNJjLwEpo2g777S+CGr1Si4/WTqop3SQRuImIf4ueVTbxNdIsK7UFTEUAhjRMRT0rxA2rCp4fIWY74IxKJnMaH8BneO3kAXHdrs64X6D2zfdoPvN5b9HWS7r70+2Bs8PT454u2SiyDqG7ywpzapZKHPaJf7mb1jg+K5zk4vH1waPKt9isfoYq2NaOiLnS5sCcxV6yyRsMGUVZUWnLEAKJA67+yAJhgjmQrXqYwj6TXq42RTjuFQn6G6+iikobmcev7MyPzNmI05nqLF8T3N5QGi/Ii0d4Mu7K5OajZl3qqbSXUpjqnoT4sOA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>, Oleksandr <olekstysh@xxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 30 Jan 2020 15:20:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHV1rQn7uvWmtBMUUCKekbfSzRsQagBzvuAgAF4XICAAAi8gIAABBYA
- Thread-topic: [PATCH] iommu/arm: Don't allow the same micro-TLB to be shared between domains
Volodymyr Babchuk writes:
Oleksandr,
[...]
>> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> index c21d2d7..411fc0f 100644
>> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> @@ -702,7 +702,12 @@ static int ipmmu_attach_device(struct
>> ipmmu_vmsa_domain *domain,
>> int ret = ipmmu_utlb_enable(domain, fwspec->ids[i]);
>>
>> if ( ret )
>> + {
>> + while ( i-- )
> You will call
>> + ipmmu_utlb_disable(domain, fwspec->ids[i]);
> for uTLB that caused the error. Likely, this uTLB right now is assigned
> for another domain. So, you will disable active uTLB which belongs to
> that domain.
Please disregard this. I realized that i-- will ensure that right index
will be used. Sorry for the noise.
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
