Re: [Xen-devel] [XEN PATCH v2 07/12] xen/build: run targets csopes, tags, .. without Rules.mk

[Jan Beulich <jbeulich@xxxxxxxx>]

On 17.01.2020 11:53, Anthony PERARD wrote:
> Those targets make use of $(all_sources) which depends on TARGET_ARCH,
> so we just need to set TARGET_ARCH earlier and once.
> 
> XEN_TARGET_ARCH isn't expected to change during the build, so
> TARGET_SUBARCH and TARGET_ARCH aren't going to change either.

In principle yes, but there's an exception which may be worth
mentioning here that it doesn't conflict: arch/x86/boot/build32.mk
overrides XEN_TARGET_ARCH (but doesn't use the remaining make
machinery).

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -35,6 +35,11 @@ SRCARCH=$(shell echo $(ARCH) | sed -e 's/x86.*/x86/' -e 
> s'/arm\(32\|64\)/arm/g')
>  # we need XEN_TARGET_ARCH to generate the proper config
>  include $(XEN_ROOT)/Config.mk
>  
> +# Set ARCH/SUBARCH appropriately.
> +export TARGET_SUBARCH  := $(XEN_TARGET_ARCH)
> +export TARGET_ARCH     := $(shell echo $(XEN_TARGET_ARCH) | \
> +                            sed -e 's/x86.*/x86/' -e s'/arm\(32\|64\)/arm/g')

Seeing this, ...

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -27,11 +27,6 @@ ifneq ($(origin verbose),undefined)
>  $(error "You must use 'make menuconfig' to enable/disable verbose now.")
>  endif
>  
> -# Set ARCH/SUBARCH appropriately.
> -override TARGET_SUBARCH  := $(XEN_TARGET_ARCH)
> -override TARGET_ARCH     := $(shell echo $(XEN_TARGET_ARCH) | \
> -                              sed -e 's/x86.*/x86/' -e 
> s'/arm\(32\|64\)/arm/g')

... where did the "override"s go?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel