[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [XEN PATCH v2 05/12] xen/include: remove include of Config.mk



On 29.01.2020 16:28, Jan Beulich wrote:
> On 17.01.2020 11:53, Anthony PERARD wrote:
>> It isn't necessary to include Config.mk here because this Makefile is
>> only used by xen/Rules.mk which already includes Config.mk.
> 
> And so is xen/test/livepatch/Makefile afaics from its parent dir
> Makefile. With this also adjusted (or it explained why I'm seeing
> things incorrectly) ...
> 
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

And now I've seen that patch 6 does just this. I think such
common theme changes are, unless patches are overly large
already, better put all in on patch. Anyway - the R-b then
is unconditional.

Another question: The cover letter doesn't say anything about
some (or most) patches here being independent of one another,
and hence the option of them going in out of order. The one
here looks to be entirely standalone, for example.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.