Re: [Xen-devel] [PATCH v4 2/7] x86/hyperv: setup hypercall page

[Wei Liu <wl@xxxxxxx>]

On Thu, Jan 23, 2020 at 01:35:22AM +0000, Michael Kelley wrote:
[...]
> > diff --git a/xen/include/asm-x86/guest/hyperv-tlfs.h b/xen/include/asm-
> > x86/guest/hyperv-tlfs.h
> > index 05c4044976..5d37efd2d2 100644
> > --- a/xen/include/asm-x86/guest/hyperv-tlfs.h
> > +++ b/xen/include/asm-x86/guest/hyperv-tlfs.h
> > @@ -318,15 +318,16 @@ struct ms_hyperv_tsc_page {
> >   *
> >   * Bit(s)
> >   * 63 - Indicates if the OS is Open Source or not; 1 is Open Source
> > - * 62:56 - Os Type; Linux is 0x100
> > + * 62:56 - Os Type; Linux 0x100, FreeBSD 0x200, Xen 0x300
> 
> This comment isn't quite right -- it reflects the mistake in the
> TLFS that is being corrected.  The field 62:56 is only 7 bits wide,
> so 0x100, 0x200, etc. won't fit.  The actual values are: Linux 0x1,
> FreeBSD 0x2, and Xen 0x3.  Then bits 55:48 are 0x00.

Thanks Michael.

I will fix this section (and perhaps submit a patch for Linux as well).

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel