Re: [Xen-devel] [PATCH] x86/suspend: disable watchdog before calling console_start_sync()

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Jan 28, 2020 at 10:55:00AM +0000, Igor Druzhinin wrote:
> On 28/01/2020 10:45, Roger Pau Monné wrote:
> > On Mon, Jan 27, 2020 at 09:29:16PM +0000, Igor Druzhinin wrote:
> >> ... and enable it after exiting S-state. Otherwise accumulated
> >> output in serial buffer might easily trigger the watchdog if it's
> >> still enabled after entering sync transmission mode.
> > 
> > Can't you just process the watchdog in serial_start_sync instead of
> > disabling it?
> 
> I think it would be layering violation. Plus in every other place we're
> enabling sync mode we're also disabling watchdog as well.

Not in every place, but indeed there's quite a lot of callers that
already disable the watchdog.

I wonder whether this should be put inside of console_start_sync
itself, and a parameter added to the function if not all callers want
the watchdog disabled (same for console_end_sync).

> I also think it's beneficial to disable watchdog before entering firmware.

I don't have objections.

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel