Re: [Xen-devel] [PATCH v1 1/4] x86/microcode: Improve documentation for ucode=

[Jan Beulich <jbeulich@xxxxxxxx>]

On 22.01.2020 23:30, Eslam Elnikety wrote:
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -2134,7 +2134,12 @@ logic applies:
>  ### ucode (x86)
>  > `= List of [ <integer> | scan=<bool>, nmi=<bool> ]`
>  
> -Specify how and where to find CPU microcode update blob.
> +    Applicability: x86

With this, the (x86) in the section title should go away, I think.

> +    Default: `nmi`
> +
> +Controls for CPU microcode loading. For early loading, this parameter can
> +specify how and where to find the microcode update blob. For late loading,
> +this parameter specifies if the update happens within a NMI handler.
>  
>  'integer' specifies the CPU microcode update blob module index. When 
> positive,
>  this specifies the n-th module (in the GrUB entry, zero based) to be used
> @@ -2152,6 +2157,7 @@ image that contains microcode. Depending on the 
> platform the blob with the
>  microcode in the cpio name space must be:
>    - on Intel: kernel/x86/microcode/GenuineIntel.bin
>    - on AMD  : kernel/x86/microcode/AuthenticAMD.bin
> +If EFI boot, the `ucode=<filename>` config takes precendence over `scan`.

"In EFI boot" is wrong, isn't it? This is for xen.efi only aiui.
Also there's a stray 'n' in "precedence".

All could be taken care of while committing, I guess, so with
this
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel