Re: [Xen-devel] [PATCH v4 08/16] tools/libvchan: notify server when client is connected

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Jan 20, 2020 at 02:44:58PM -0500, Jason Andryuk wrote:
> On Tue, Jan 14, 2020 at 9:42 PM Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Let the server know when the client is connected. Otherwise server will
> > notice only when client send some data.
> > This change does not break existing clients, as libvchan user should
> > handle spurious notifications anyway (for example acknowledge of remote
> > side reading the data).
> >
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > ---
> > I had this patch in Qubes for a long time and totally forgot it wasn't
> > upstream thing...
> > ---
> >  tools/libvchan/init.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/tools/libvchan/init.c b/tools/libvchan/init.c
> > index 180833d..50a64c1 100644
> > --- a/tools/libvchan/init.c
> > +++ b/tools/libvchan/init.c
> > @@ -447,6 +447,9 @@ struct libxenvchan *libxenvchan_client_init(struct 
> > xentoollog_logger *logger,
> >         ctrl->ring->cli_live = 1;
> >         ctrl->ring->srv_notify = VCHAN_NOTIFY_WRITE;
> >
> > +    /* wake up the server */
> > +    xenevtchn_notify(ctrl->event, ctrl->event_port);
> 
> Looks like you used 4 spaces, but the upstream file uses hard tabs.

Indeed. CODING_STYLE says spaces, but it also says some tools/* are not
directly covered by this file. Should I use this occasion to convert
tools/libvchan/* to spaces (in a separate patch), or keep tabs (and
adjust my patch)?

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel