[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 04/16] libxl: Allow running qemu-xen in stubdomain
On Mon, Jan 20, 2020 at 01:56:51PM -0500, Jason Andryuk wrote: > On Tue, Jan 14, 2020 at 9:41 PM Marek Marczykowski-Górecki > <marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > Do not prohibit anymore using stubdomain with qemu-xen. > > To help distingushing MiniOS and Linux stubdomain, add helper inline > > functions libxl__stubdomain_is_linux() and > > libxl__stubdomain_is_linux_running(). Those should be used where really > > the difference is about MiniOS/Linux, not qemu-xen/qemu-xen-traditional. > > > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> > > > > --- > > Changes in v3: > > - new patch, instead of "libxl: Add "stubdomain_version" to > > domain_build_info" > > - helper functions as suggested by Ian Jackson > > --- > > <snip> > > > --- a/tools/libxl/libxl_internal.h > > +++ b/tools/libxl/libxl_internal.h > > @@ -2299,6 +2299,23 @@ _hidden int > > libxl__device_model_version_running(libxl__gc *gc, uint32_t domid); > > /* Return the system-wide default device model */ > > _hidden libxl_device_model_version libxl__default_device_model(libxl__gc > > *gc); > > > > +static inline > > +bool libxl__stubdomain_is_linux_running(libxl__gc *gc, uint32_t domid) > > This is unused in the series, as far as I can tell. Yes, all the calls are commented out, as exact same condition is implied from the context. But I think a canonical function to do that is still useful, if needed anywhere in the codebase in the future. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |