Re: [Xen-devel] [Qemu-devel] [PATCH] trivial: Remove xenfb_enabled from sysemu.h

[Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>]

On 1/21/20 5:17 PM, Thomas Huth wrote:
> The define is only used in one other place. Move the code there
> instead of keeping this xen-specific define in sysemu.h.
>
> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>

> ---
>   hw/xenpv/xen_machine_pv.c | 2 +-
>   include/sysemu/sysemu.h   | 1 -
>   2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c
> index 3a8af1a1e0..8df575a457 100644
> --- a/hw/xenpv/xen_machine_pv.c
> +++ b/hw/xenpv/xen_machine_pv.c
> @@ -60,7 +60,7 @@ static void xen_init_pv(MachineState *machine)
>       xen_be_register("qnic", &xen_netdev_ops);
>   
>       /* configure framebuffer */
> -    if (xenfb_enabled) {
> +    if (vga_interface_type == VGA_XENFB) {
>           xen_config_dev_vfb(0, "vnc");
>           xen_config_dev_vkbd(0);
>       }
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 80c57fdc4e..2ccf216158 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -32,7 +32,6 @@ typedef enum {
>   } VGAInterfaceType;
>   
>   extern int vga_interface_type;
> -#define xenfb_enabled (vga_interface_type == VGA_XENFB)
>   
>   extern int graphic_width;
>   extern int graphic_height;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel