[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2] ns16550: Add ACPI support for ARM only
- To: Jan Beulich <jbeulich@xxxxxxxx>, Wei Xu <xuwei5@xxxxxxxxxxxxx>
- From: Julien Grall <julien@xxxxxxx>
- Date: Tue, 21 Jan 2020 11:16:07 +0000
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Linuxarm <linuxarm@xxxxxxxxxx>, Shameerali Kolothum Thodi <shameerali.kolothum.thodi@xxxxxxxxxx>, "Zengtao \(B\)" <prime.zeng@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 21 Jan 2020 11:16:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21/01/2020 11:13, Jan Beulich wrote:
+ if ( ACPI_FAILURE(status) )
+ {
+ printk("ns16550: Failed to get SPCR table\n");
Is such a message warranted? I.e. wouldn't it trigger on all
systems not having the table, which is hardly what you/we want?
+ return -EINVAL;
Also, is it really an error if there's no such table?
You can only be there if the arm-uart.c found an SPCR table. So this is
a sanity check. Therefore I think the error message is warrant here.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
