Re: [Xen-devel] [PATCH v3 1/2] xsm: add config option for denied string

[Jan Beulich <jbeulich@xxxxxxxx>]

On 17.01.2020 17:44, Sergey Dyasli wrote:
> Signed-off-by: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>

In principle
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

But I think it would be nice to have a non-empty description, at
least to reason why the option addition is deemed useful.

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -236,6 +236,14 @@ choice
>               bool "SILO" if XSM_SILO
>  endchoice
>  
> +config XSM_DENIED_STRING
> +     string "xen_version denied string"

I guess inserting "hypercall" into this prompt would set better
context without needing to resort to the help text, i.e.
"xen_version hypercall denied string". Thoughts?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel