Re: [Xen-devel] [PATCH v4 10/18] x86/mem_sharing: Replace MEM_SHARING_DEBUG with gdprintk

[Jan Beulich <jbeulich@xxxxxxxx>]

On 08.01.2020 18:14, Tamas K Lengyel wrote:
> @@ -494,19 +491,19 @@ static int audit(void)
>          /* If we can't lock it, it's definitely not a shared page */
>          if ( !mem_sharing_page_lock(pg) )
>          {
> -            MEM_SHARING_DEBUG(
> -                "mfn %lx in audit list, but cannot be locked (%lx)!\n",
> -                mfn_x(mfn), pg->u.inuse.type_info);
> -            errors++;
> -            continue;
> +            gdprintk(XENLOG_ERR,
> +                     "mfn %lx in audit list, but cannot be locked (%lx)!\n",
> +                     mfn_x(mfn), pg->u.inuse.type_info);
> +           errors++;
> +           continue;

There looks to be one space too little on these last two lines and ...

> @@ -514,24 +511,24 @@ static int audit(void)
>          /* Check the page owner. */
>          if ( page_get_owner(pg) != dom_cow )
>          {
> -            MEM_SHARING_DEBUG("mfn %lx shared, but wrong owner %pd!\n",
> -                              mfn_x(mfn), page_get_owner(pg));
> -            errors++;
> +               gdprintk(XENLOG_ERR, "mfn %lx shared, but wrong owner 
> (%hu)!\n",
> +                        mfn_x(mfn), page_get_owner(pg)->domain_id);
> +               errors++;

... a few too many here and ...

>          }
>  
>          /* Check the m2p entry */
>          if ( !SHARED_M2P(get_gpfn_from_mfn(mfn_x(mfn))) )
>          {
> -            MEM_SHARING_DEBUG("mfn %lx shared, but wrong m2p entry (%lx)!\n",
> -                              mfn_x(mfn), get_gpfn_from_mfn(mfn_x(mfn)));
> -            errors++;
> +               gdprintk(XENLOG_ERR, "mfn %lx shared, but wrong m2p entry 
> (%lx)!\n",
> +                        mfn_x(mfn), get_gpfn_from_mfn(mfn_x(mfn)));
> +               errors++;

... here.

Also please switch to the %pd format for domain IDs you log
anywhere here.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel