[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] net: xen-netbank: hash.c: Use built-in RCU list checking
- To: Wei Liu <wei.liu@xxxxxxxxxx>
- From: Madhuparna Bhowmik <madhuparnabhowmik04@xxxxxxxxx>
- Date: Wed, 15 Jan 2020 21:16:21 +0530
- Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxx>, paul@xxxxxxx, netdev@xxxxxxxxxxxxxxx, Amol Grover <frextrite@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel-mentees@xxxxxxxxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx
- Delivery-date: Wed, 15 Jan 2020 15:46:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jan 15, 2020 at 07:36:38PM +0530, Madhuparna Bhowmik wrote:
[...]
>
> > The surrounding code makes it pretty clear that the lock is already held
> > by the time list_for_each_entry_rcu is called, yet the checking involved
> > in lockdep_is_held is not trivial, so I'm afraid I don't consider this a
> > strict improvement over the existing code.
> >
> > Actually, we want to make CONFIG_PROVE_LIST_RCU enabled by default.
I think you meant CONFIG_PROVE_RCU_LIST.
I am sorry about this. Yes, I meant CONFIG_PROVE_RCU_LIST.
> And if the cond argument is not passed when the usage of
> list_for_each_entry_rcu()
> is outside of rcu_read_lock(), it will lead to a false positive.
> Therefore, I think this patch is required.
Fair enough.
Thank you, Madhuparna
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|