Re: [Xen-devel] [PATCH 17/20] tools/libx[cl]: Plumb static_data_done() up into libxl

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Andrew Cooper writes ("[PATCH 17/20] tools/libx[cl]: Plumb static_data_done() 
up into libxl"):
>  /* callbacks provided by xc_domain_restore */
>  struct restore_callbacks {
> +    /*
> +     * Called once the STATIC_DATA_END record has been received/inferred.
> +     * Passes in the blocks of static data which have not been received, 
> which
> +     * the higher level toolstack must provide backwards compatibility for.
> +     */
> +#define XGR_SDD_MISSING_CPUID (1 << 0)
> +#define XGR_SDD_MISSING_MSR   (1 << 1)
> +    int (*static_data_done)(unsigned int missing, void *data);

This is a bit weird, isn't it ?  I mean: if these blocks of data *are*
received then libxc handles them; but if they are not, libxc's caller
must do so.

I appreciate that the interface at the top of libxc is already rather
complex and uneven but this doesn't seem to be helping...

The actual code looks OK to me.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel