Re: [Xen-devel] [PATCH 05/12] tools/migration: Drop IHDR_VERSION constant from libxc and python

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Andrew Cooper writes ("[PATCH 05/12] tools/migration: Drop IHDR_VERSION 
constant from libxc and python"):
> Migration v3 is in the process of being introduced, meaning that the code has
> to cope with both versions.  Use an explicit 2 for now.
> 
> For the verify-stream-v2 and convert-legacy-stream scripts, update text to say
> "v2 (or later)".  What matters is the distinction vs legacy streams.

How about introducing
  enum { IHDR_VERSION_2 = 2 }
or some such ?

In C it can be hard otherwise to find all the relevant tests.  Being
able to grep for IHDR_VERSION would help.  So I would prefer manifest
constants of some kind to unvarnished integers.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel