[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/12] libxc/migration: Rationalise the 'checkpointed' field to 'stream_type'


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Tue, 14 Jan 2020 15:58:30 +0000
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 14 Jan 2020 15:58:51 +0000
  • Ironport-sdr: Cgdtah5DCMzipC/KeA5txJddBVqc+Fl79TtgN6cEwRW887Hx2Ps0Qo2tI2J8b0MTEck8GDntbt lby7jR0W0r3mzEP2BxRu8m9w48PkcdNNgKNJFVbI0aaSdQ9SE0lpCXJn0Q2k2OZmwn1Wr9A4nL Rb0jIkyw3m90RTITuEpUQLXJ19yUNyXTCPFA7CH1X57mA88Mk9B8doLoCwhnSlO1A/qo34JWhD VIVl+zFqaGGvO42ePMnNAESUzgD6czjD1AKbhSlB4BT+WAmGzv0x7Jh2ONK0FKQhN84U1Dt1wV Teo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Andrew Cooper writes ("[PATCH 03/12] libxc/migration: Rationalise the 
'checkpointed' field to 'stream_type'"):
> Originally, 'checkpointed' was a boolean signalling the difference between a
> plain and a Remus stream.  COLO was added later, but several bits of code
> retained boolean-style logic.  While correct, it is confusing to follow.
> 
> Additionally, XC_MIG_STREAM_NONE means "no checkpoints" but reads as "no
> stream".
> 
> Consolidate all the logic on the term 'stream_type', and rename STREAM_NONE
> to STREAM_PLAIN.  Re-position the stream_type variable so it isn't
> duplicated in both the save and restore unions.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.