[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 3/4] xen/domain: Remove #ifndef surrounding alloc_pirq_struct()
Hi Jan, On 14/01/2020 09:37, Jan Beulich wrote: On 13.01.2020 22:33, Julien Grall wrote:--- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -41,9 +41,7 @@ struct vcpu *alloc_vcpu_struct(const struct domain *d); void free_vcpu_struct(struct vcpu *v);/* Allocate/free a PIRQ structure. */-#ifndef alloc_pirq_struct struct pirq *alloc_pirq_struct(struct domain *); -#endif void free_pirq_struct(void *);Is this really a helpful change. Back then ia64 had a #define for this, and a future port may want to do so as well. I did notice it was used by ia64 but I am unconvinced this is going to be used in the future. Most likely because there is singler caller for alloc_pirq_struct() and this is not a hot path. So using a static inline/macro is not really a good solution here. Yes, this doesn't reduce the amount of unused code we have and will unlikely to be used in the future. If we really need it then we can re-introduce it.Is there anything actively problematic with leaving this untouched? Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |