Re: [Xen-devel] [PATCH 2/2] Remove undocumented and unmaintained tools/memshr library

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Fri, Jan 10, 2020 at 10:59 AM Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 10/01/2020 02:30, Tamas K Lengyel wrote:
> > The library has been largely untouched for over a decade at this point, it 
> > is
> > undocumented and it's unclear what it was originally used for. Remove it 
> > from
> > tree, if anyone needs it in the future it can be carved out from git 
> > history.
> >
> > Signed-off-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
>
> Hmm - this is a little awkward.  You remove yourself as maintainer of
> this code, then delete it.
>
> I suspect what you want to do is have patch 1 simply add tools/test
> saying "include other memshr content", and this patch delete
> tools/memshr including the entry in the maintainers file.  (Can be fixed
> up on commit of course, seeing as this is the only issue.)
>
> Overall, I agree with the change, but it will need a tools ack.
>

I was considering just squashing the two patches into one but wasn't
sure if anyone would object to removing dead code (that seems to be
never done). So if there is no objection and the only problem is
"ordering", it would be simpler to just squash the two into one during
commit.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel