[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH V6 2/4] x86/altp2m: Add hypercall to set a range of sve bits
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- Date: Mon, 6 Jan 2020 09:21:07 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rvWxfLNFhmyNtKz2R+X0EbjliBjbP+1TBYbwQL0H9Io=; b=Qjkgtl6FiSBGkAsSkT1GNQcklOcx/o0xZuaVe8hvvTBd0NNmLA0rpQKyRJeBbHIPcGcI/LAI2dc1yM+T42aaSV3RsJdF1POspFio/Zz2nl9GiEReaXxM3+Veu930SDzWOi/9gcsG8TyTBIqunlLXkSq3MHZsj8Hi67GrFpBp99Rfqsh82t5hD6MEigEzV6uBrxYXCygtoQC6rM6dPDya3Nx9EvDfSk2+vDGgpqUM6eQyO7CkX/b0YIheqp9q63/5D4AkVKFWpajvsu7YcVWmTzsdVWtOuFm4EULpsMNZSxKPdr86pnJUK1/IlQhBDsjPnWGQTrTSie0U6y0NwDJz+Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PMTZfZdeCu5pRkh7cBpfTIoNQX0aC/XC808s+l8pRK/VQPZ6cd6XOzP/lD2Bz4UnRE0Yokn0vxBoOYVEFbTil2Rpj1s9Bnkjp4GllRbc73VNRdfCEvTcX//0CduzLw3y0SIlUk9FlFqw9aSEMf9HJRjYBuCNWkMf9D/vbtcbLZdXJeger/DEDGxVIkOjK0DrS4SoUmTGe0I96vXyaFrabH1pr6+5ry31sAIp0rIR0giM9KhHzrrstWeQstHIOpc/BwYtR1vabsQLps6+RzpF12QPr3o1HyWfc/i7zqPLMc0Lu47EFqzpw7XU0QhPJSCgDq0F9G4KphmAsN9Rfa94kw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 06 Jan 2020 09:26:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVuZnoQDql7d7Su0+P124sSAtk36fH6bYAgBWIVIA=
- Thread-topic: [PATCH V6 2/4] x86/altp2m: Add hypercall to set a range of sve bits
On 23.12.2019 18:31, Tamas K Lengyel wrote:
>> diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
>> index 4fc919a9c5..de832dcc6d 100644
>> --- a/xen/arch/x86/mm/p2m.c
>> +++ b/xen/arch/x86/mm/p2m.c
>> @@ -3070,6 +3070,70 @@ out:
>> return rc;
>> }
>>
>> +/*
>> + * Set/clear the #VE suppress bit for multiple pages. Only available on
>> VMX.
>> + */
>
> I have to say I find it a bit odd why this function is in p2m.c but
> it's declaration...
>
>> +int p2m_set_suppress_ve_multi(struct domain *d,
>> + struct xen_hvm_altp2m_suppress_ve_multi *sve)
>> +{
>
> ...
>
>> diff --git a/xen/include/xen/mem_access.h b/xen/include/xen/mem_access.h
>> index e4d24502e0..00e594a0ad 100644
>> --- a/xen/include/xen/mem_access.h
>> +++ b/xen/include/xen/mem_access.h
>> @@ -75,6 +75,9 @@ long p2m_set_mem_access_multi(struct domain *d,
>> int p2m_set_suppress_ve(struct domain *d, gfn_t gfn, bool suppress_ve,
>> unsigned int altp2m_idx);
>>
>
> .. in mem_access.h?
>
>> +int p2m_set_suppress_ve_multi(struct domain *d,
>> + struct xen_hvm_altp2m_suppress_ve_multi
>> *suppress_ve);
>> +
>
> I mean, even altp2m.h would make sore sense for this. So what's the
> rational behind that?
>
Indeed it's odd but p2m_set_suppress_ve() is declared above this. I
don't now how it got there in the first place but I just followed that
pattern.
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
