Re: [Xen-devel] [PATCH 4/9] go/xenlight: Fix CpuidPoliclyList conversion

[Nick Rosbrook <rosbrookn@xxxxxxxxx>]

> Empty Go strings should be converted to `nil` libxl_cpuid_policy_list;
> otherwise libxl_cpuid_parse_config gets confused.
>
> Also, libxl_cpuid_policy_list returns a weird error, not a "normal"
> libxl error; if it returns one of these non-standard errors, convert
> it to ErrorInval.
>
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Looks good to me. If "golang/xenlight: begin Go to C type marshaling"
is committed before this, the signature of toC will need to be updated
as per your suggestion.

Otherwise,

Reviewed-by: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel