Re: [Xen-devel] [PATCH 2/6] libxl_create: make 'soft reset' explicit

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Paul Durrant writes ("[PATCH 2/6] libxl_create: make 'soft reset' explicit"):
> The 'soft reset' code path in libxl__domain_make() is currently taken if a
> valid domid is passed into the function. A subsequent patch will enable
> higher levels of the toolstack to determine the domid of newly created or
> restored domains and therefore this criteria for choosing 'soft reset'
> will no longer be usable.
> 
> This patch adds an extra boolean option to libxl__domain_make() to specify
> whether it is being invoked in soft reset context and appropriately
> modifies callers to choose the right value. To facilitate this, a new
> 'soft_reset' boolean field is added to struct libxl__domain_create_state
> and the 'domid_soft_reset' field is renamed to 'domid' in anticipation of
> its wider remit. For the moment do_domain_create() will always set
> domid to INVALID_DOMID and hence we can add an assertion into
> libxl__domain_create() that, if it is not called in soft reset context,
> the passed in domid is exactly that value.
> 
> Whilst in the neighbourhood, some checks of 'restore_fd > -1' have been
> replaced by 'restore_fd >= 0' to be more conventional and consistent with
> checks of 'restore_fd < 0'.

Thanks, nice work.  (In general my preference would be to split stuff
like that last bit out into a pre-patch but this is a trivial
observation.)

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel