Re: [Xen-devel] [PATCH 2/2] Use ip for bridge related functions where brctl is not present

[Wei Liu <wl@xxxxxxx>]

On Fri, Dec 13, 2019 at 03:08:35PM +1100, Steven Haigh wrote:
> Signed-off-by: Steven Haigh <netwiz@xxxxxxxxx>
> ---
>  tools/hotplug/Linux/colo-proxy-setup      | 30 +++++++++++++++++------
>  tools/hotplug/Linux/vif-bridge            | 19 ++++++++------
>  tools/hotplug/Linux/vif2                  | 12 +++++++--
>  tools/hotplug/Linux/xen-network-common.sh | 15 +++++++++---
>  4 files changed, 55 insertions(+), 21 deletions(-)
> 
> diff --git a/tools/hotplug/Linux/colo-proxy-setup 
> b/tools/hotplug/Linux/colo-proxy-setup
> index 94e2034452..cbd5b773c6 100755
> --- a/tools/hotplug/Linux/colo-proxy-setup
> +++ b/tools/hotplug/Linux/colo-proxy-setup
> @@ -76,10 +76,17 @@ function teardown_primary()
>  
>  function setup_secondary()
>  {
> -    do_without_error brctl delif $bridge $vifname
> -    do_without_error brctl addbr $forwardbr
> -    do_without_error brctl addif $forwardbr $vifname
> -    do_without_error brctl addif $forwardbr $forwarddev
> +    if [ -x "/usr/sbin/brctl" ]; then

I agree with the general direction of this patch, thanks for puting
together this patch.

Instead of specifying full path here, please use `which brctl` like we
did in xen-network-common.sh.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel