Re: [Xen-devel] [PATCH] console: avoid buffer overrun in guest_console_write()

[Julien Grall <julien@xxxxxxx>]

Hi,

On 29/11/2019 14:15, Jan Beulich wrote:
> conring_puts() has been requiring a nul-terminated string, which the
> local kbuf[] doesn't get set for anymore. Add a length parameter to the
> function, just like was done for others, thus allowing embedded nul to
> also be read through XEN_SYSCTL_readconsole.
>
> While there drop a stray cast: Both operands of - are already uint32_t.
>
> Fixes: ea601ec9995b ("xen/console: Rework HYPERCALL_console_io interface")
Sorry again :(.

> Reported-by: Jürgen Groß <jgross@xxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Julien Grall <julien@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel