[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jürgen Groß <jgross@xxxxxxxx>
- Date: Fri, 29 Nov 2019 13:19:18 +0100
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <pdurrant@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 29 Nov 2019 12:19:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.11.19 13:17, Jan Beulich wrote:
On 29.11.2019 13:01, Jürgen Groß wrote:
On 29.11.19 11:22, Jan Beulich wrote:
On 28.11.2019 17:52, Paul Durrant wrote:
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -84,11 +84,40 @@ struct grant_table {
struct grant_table_arch arch;
};
+static int parse_gnttab_limit(const char *param, const char *arg,
+ unsigned int *valp)
+{
+ const char *e;
+ unsigned long val;
+
+ val = simple_strtoul(arg, &e, 0);
+ if ( *e )
+ return -EINVAL;
+
+ if ( val > INT_MAX )
+ return -ERANGE;
+
+ return 0;
+}
*valp doesn't get written to anymore. With this fixed (and no new
issues introduced ;-) ) hypervisor side
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
And:
Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
Noted, but - ahead of a tool stack side ack? I.e. valid indefinitely
no matter when that one would arrive?
We agreed this one to be a blocker, right?
Nevertheless: tools maintainers, please?
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|