Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

[Julien Grall <julien.grall.oss@xxxxxxxxx>]

On Thu, 28 Nov 2019, 18:09 Stefano Stabellini, <sstabellini@xxxxxxxxxx> wrote:

On Thu, 28 Nov 2019, Julien Grall wrote:
> > In both cases I see no reason to keep wrong code.
> >
> > Either the patch will let run Linux 5.4 fine - then the patch should
> > definitely be taken.
> That's up to Stefano and Peng to provide me information why this is fine.
> FAOD, the current justification provided is not acceptable for me.

I disagree. This is a typo fix. The original design was never spec
compliant. You cannot expect the typo fix to explain why the original
behavior is tolerable. That is out of scope and should *not* be required
for this fix.

May I remind you that as a maintainer, this is in my right to say no to a patch.

We cannot expect typo fixes to go and trigger vgic/gic reworks and deep
investigations. This is a wrong expectation now, and going forward.

That's the best way to turn Xen into a bunch of hacks.

 

I pointed out several times a potential issue with this patch. I also spent some part of my week-end investigating it and provide some insight. Did you look at them?

If you want this patch in, then please help explaining why 5.4 is going to run fine on Xen 4.13 rather than keeping arguing this is a typo fix.

Cheers,

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel