[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack
On 28.11.2019 14:53, Andrew Cooper wrote: > On 28/11/2019 12:10, Andrew Cooper wrote: >> On 28/11/2019 11:03, Jan Beulich wrote: >>> Notes: >>> >>> - In principle we could get away without the check_eoi_deferral flag. >>> I've introduced it just to make sure there's as little change as >>> possible to unaffected paths. >>> - Similarly the cpu_has_pending_apic_eoi() check in do_IRQ() isn't >>> strictly necessary. >> I don't think the cpu_has_pending_apic_eoi() check is necessary. It is >> checked at the head of end_nonmaskable_irq() as well. >> >> Similarly, I'm not sure that check_eoi_deferral is something that we'd >> want to introduce. >> >> I'll drop both of these and test, seeing as I have a repro of the problem. > > Dropping cpu_has_pending_apic_eoi() wasn't possible in a trivial way (so > I didn't), and dropping just check_eoi_deferral on its own definitely > breaks things. > > Given the 4.13 timeline, lets go with it in this form, seeing as it is > the version which had all of last night's worth of testing. > > Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > Tested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Thanks! I've taken note to produce a patch (if possible at all, given the results of your attempt) to remove the extra pieces again, ideally to go in pretty soon after the branching. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |