Re: [Xen-devel] [PATCH] tools/arm: include xen-tools/libs.h from libxl_arm_acpi.c

[Wei Liu <wl@xxxxxxx>]

On Thu, Nov 28, 2019 at 11:30:34AM +0100, Jürgen Groß wrote:
> On 28.11.19 11:15, Wei Liu wrote:
> > On Wed, Nov 27, 2019 at 06:24:58PM -0800, Stefano Stabellini wrote:
> > > libxl_arm_acpi.c is using BUILD_BUG_ON but it is not including
> > > xen-tools/libs.h that defines it.
> > > 
> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > 
> > Acked-by: Wei Liu <wl@xxxxxxx>
> > 
> > Juergen, this is a trivial patch. I think it can go in 4.13.
> 
> Why is this patch needed?
> 
> tools/libxl/libxl_arm_acpi.c includes libxl_arm.h, which includes
> libxl_internal.h, which includes xen-tools/libs.h.

Oh I missed that.

In that case I don't think this patch is required for 4.13.

Stefano, did you see a build error or something?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel