Re: [Xen-devel] [XEN PATCH v3 03/11] xen: arm: Refactor route_irq_to_guest

[Julien Grall <julien@xxxxxxx>]

Hi,

On 15/11/2019 20:01, Stewart Hildebrand wrote:
> From: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> Split out the bit which allocates the struct irqaction and calls
> __setup_irq into a new function (setup_guest_irq). I'm going to want
> to call this a second time in a subsequent patch.
>
> Note that the action is now allocated and initialised with the desc
> lock held (since it is taken by the caller). I don't think this is an
> issue (and avoiding this would make things more complex)
>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxxxxxxxxxx>
> ---
> v2: New patch (maybe, it's been a while...)
>
> v3: Rebase + trivial fixups
>
> ---
> Note: I have not given much thought regarding Julien's comment in [1]
>
> [1] https://lists.xenproject.org/archives/html/xen-devel/2015-11/msg01041.html
I would rather avoid to do memory allocation with interrupts disabled.

You may need to introduce a new function that will allocate/setup the 
action, but I think this is worth the trouble. Note that the new 
function could likely be re-used in request_irq() as well.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel