Re: [Xen-devel] [PATCH v5 00/12] livepatch: new features and fixes

["Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>]

> On 20. Nov 2019, at 03:25, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 
> wrote:
> 
> On Thu, Nov 14, 2019 at 01:06:41PM +0000, Pawel Wieczorkiewicz wrote:
>> This series introduces new features to the livepatch functionality as
>> briefly discussed during Xen Developer Summit 2019: [a] and [b].
>> It also provides a few fixes and some small improvements.
>> 
>> Main changes in v4:
>> - Fix various typos and minor issues
>> - Simplify arch_livepatch_{apply,revert} by using
>>  common_livepatch_{apply,revert}
>> - Improve python bindings and fix few issues
> 
> This is https://github.com/konradwilk/xen.git (your patches on top of 
> staging):
> 
> On ARM64:
> root@hikey960:/home/linaro# xl info
> 

<snip>

> root@hikey960:/home/linaro/xen.git/xen/test/livepatch# xen-livepatch load 
> xen_hello_world.livepatch 
> Uploading xen_hello_world.livepatch... completed
> Applying xen_hello_world... failed
> Error 22: Invalid argument
> Unloading xen_hello_world... failed
> Error 22: Invalid argument
> root@hikey960:/home/linaro/xen.git/xen/test/livepatch# git log
> commit 9f5f25f07a64e1b447f7bd124182a1c5ef422d6f
> Author: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
> Date:   Thu Nov 14 13:06:52 2019 +0000
> 
>    livepatch: Add metadata runtime retrieval mechanism
> ...
> 
> 

<snip>

> oot@hikey960:/# xen-livepatch list
> ID                                     | status     | metadata
> ----------------------------------------+------------+---------------
> xen_hello_world                         | CHECKED    | LIVEPATCH_RULEZ
> root@hikey960:/# xl debug-keys x
> (XEN) 'x' pressed - Dumping all livepatch patches
> (XEN) build-id: 8bf9ec5fc0053f4d4fc3b7d256b66ec86f8e5ccc
> (XEN)  name=xen_hello_world state=CHECKED(1) 0000000000a02000 
> (.data=0000000000a03000, .rodata=0000000000a04000) using 3 pages.
> (XEN) livepatch: module metadata:
> (XEN) livepatch:   LIVEPATCH_RULEZ
> (XEN)     xen_extra_version patch 0000000000242158(12) with 0000000000a02000 
> (16)
> (XEN) build-id=50159adec7aaec9dae8a6ce3ac6c2d5f9e825bff
> (XEN) depend-on=8bf9ec5fc0053f4d4fc3b7d256b66ec86f8e5ccc
> (XEN) depend-on-xen=8bf9ec5fc0053f4d4fc3b7d256b66ec86f8e5ccc
> root@hikey960:/# xen-livepatch unload xen_hello_world
> Unloading xen_hello_world... failed
> Error 22: Invalid argument
> root@hikey960:/# xen-livepatch list
> ID                                     | status     | metadata
> ----------------------------------------+------------+---------------
> xen_hello_world                         | CHECKED    | LIVEPATCH_RULEZ
> 
> 
> Thoughts? 

Yes, this hunk is missing (somehow it did not make it to the v5 patchset, 
sorry):

diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c
index 7747ea83aa..0b21a6aca4 100644
--- a/tools/libxc/xc_misc.c
+++ b/tools/libxc/xc_misc.c
@@ -976,6 +976,7 @@ static int _xc_livepatch_action(xc_interface *xch,
     sysctl.u.livepatch.u.action.cmd = action;
     sysctl.u.livepatch.u.action.timeout = timeout;
     sysctl.u.livepatch.u.action.flags = flags;
+    sysctl.u.livepatch.u.action.pad = 0;

     sysctl.u.livepatch.u.action.name = def_name;
     set_xen_guest_handle(sysctl.u.livepatch.u.action.name.name, name);


Best Regards,
Pawel Wieczorkiewicz






Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel