Re: [Xen-devel] [XEN PATCH for-4.13] xen: Fix race to build arch/x86/efi/relocs-dummy.o

[Jan Beulich <jbeulich@xxxxxxxx>]

On 14.11.2019 19:05, Anthony PERARD wrote:
> With $(TARGET).efi depending on efi/relocs-dummy.o, arch/x86/Makefile
> will attempt to build that object. This result in the dependency file
> been generated with relocs-dummy.o depending on efi/relocs-dummy.o.

I cannot confirm this, what I see is

efi/relocs-dummy.o: efi/relocs-dummy.S \
 ...

Which isn't to say there's no issue here. IOW the actual adjustment
is ...

> Then, when arch/x86/efi/Makefile tries to build relocs-dummy.o, well
> efi/relocs-dummy.S doesn't exist.
> 
> Have only one makefile responsible for building relocs-dummy.o.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

But I'd prefer if the description aspect could either be clarified
(different versions of make behaving differently?) or adjusted.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel