Re: [Xen-devel] [PATCH for-4.13] x86/clang: move and fix .skip check

[Jan Beulich <jbeulich@xxxxxxxx>]

On 14.11.2019 10:59, Roger Pau Monne wrote:
> .skip is only used by x86 code, so place the clang .skip with labels
> check in x86/Rules.mk instead of the top level Rules.mk. While there
> also fix an issue with it by removing the '\n' which triggers the
> following error:
> 
> <stdin>:1:31: error: missing terminating '"' character 
> [-Werror,-Winvalid-pp-token]
> void _(void) { asm volatile ( ".L0:
>                               ^
> <stdin>:1:31: error: expected string literal in 'asm'
> <stdin>:3:18: error: missing terminating '"' character 
> [-Werror,-Winvalid-pp-token]
> .skip (.L1 - .L0)" ); }
>                  ^
> <stdin>:3:24: error: expected ')'
> .skip (.L1 - .L0)" ); }
>                        ^
> <stdin>:1:29: note: to match this '('
> void _(void) { asm volatile ( ".L0:
>                             ^
> <stdin>:3:24: error: expected '}'
> .skip (.L1 - .L0)" ); }
>                        ^
> <stdin>:1:14: note: to match this '{'
> void _(void) { asm volatile ( ".L0:
>              ^
> 5 errors generated.

As said on the other thread - I'm afraid there's more to this difference
in un-escaping between your and my environments. I agree the newlines
aren't needed here at all, so I'd be fine to give my R-b, but we need to
fully understand the differences in observed behavior anyway.

Additionally I wonder whether you wouldn't better retain the original
sequence of checks, by placing the check you move at the beginning of
the "ifeq ($(clang),y)" block in x86/Rules.mk instead of at the end.
That'll (iirc) also better represent the history of the addition of
these checks (also demonstrated by the reference bug numbers).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel