Re: [Xen-devel] [PATCH] tools: pygrub actually cross-compiles just fine

[Wei Liu <wl@xxxxxxx>]

On Thu, Nov 07, 2019 at 10:22:23AM -0800, Stefano Stabellini wrote:
> On Thu, 7 Nov 2019, Wei Liu wrote:
> > On Wed, Nov 06, 2019 at 08:10:47AM -0800, Stefano Stabellini wrote:
> > > On Wed, 6 Nov 2019, Wei Liu wrote:
> > > > On Tue, Nov 05, 2019 at 03:51:13PM -0800, Stefano Stabellini wrote:
> > > > > Actually, pygrub cross-compiles without issues. The cross-compilation
> > > > > work-around goes back to 2005 and it probably referred to PowerPC.
> > > > > 
> > > > > Remove the work-around now.
> > > > > 
> > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > > > > CC: Christopher Clark <christopher.w.clark@xxxxxxxxx>
> > > > 
> > > > Presumably you tried to cross-compile it for Arm? It would be good to
> > > > mention that in the commit message.
> > > > 
> > > > I think the content of this patch is fine:
> > > 
> > > It cross-compiles fine for aarch64 on x86_64 with Yocto.  Although we
> > > don't do any cross-compilations in OSSTest as far as I know, so applying
> > > the patch won't break OSSTest, given the state of the release, I think
> > > it would be best to wait for the next merge window.
> > 
> > That's of course fine by me.
> 
> I'll resend the patch with a better commit message. It would be good to
> get an ack if you are OK with it (of course there will be no committing
> it right now.)

Acked-by: Wei Liu <wl@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel