[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [XEN PATCH for-4.13 v2 0/4] libxl: gentypes: initialise array elements in json


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Date: Tue, 29 Oct 2019 15:54:32 +0000
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Jürgen Groß <jgross@xxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 29 Oct 2019 15:54:52 +0000
  • Ironport-sdr: ju3QcWiEd95+M+1L5z6vr0sPJfrSkKaBVA+f2vv6pAEnRKnIRj/eI77cxhiacDzE6yZW0TDD0c jxh2bIoIPrg43peEmfs0oTvGB5xfRk1sMmT0/4xrmWFCSwyFmwlL8DYaoqN5mY0rdEN+SVNgr8 ZBzqE4VNmkK6UHWZZWh+JXRbUPLh2EBCctpRhmq5BuUzejRlw4EhRxWp/bZGxfx/z0qbP9PKtF /6kt8Z2+EwUf5ppfY8Viu8T6Teq+EYiGNaarLcFehEGglMWP/IyQznj6/JSbGIIVYrKeLf3gYh z2A=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Oleksandr Grytsov discovered that the libxl json idl parsing fails to
properly initialise array elements.

Fixing this is not entirely straightforward, because the code to do
the initialisation is not conveniently available as a separate
function.

To ease debugging and review, I have broken this patch up into 4 very
small refactorings which do not change the output, plus the one patch
to call the newly-provided initialiser.

I think this version addresses comments from Julien Grall on earlier
versions.  IMO it is a candiate for 4.13, and also backporting.

Ian Jackson (3):
  tools/libxl: gentypes.py: Prefer init_val to init_fn
  libxl: gentypes.py: Break out field_pass in ..._copy_deprecated
  libxl: gentypes.py: Break out libxl_C_type_do_init

Oleksandr Grytsov (1):
  libxl: gentypes: initialise array elements in json

 tools/libxl/gentypes.py | 35 ++++++++++++++++++++++-------------
 1 file changed, 22 insertions(+), 13 deletions(-)

-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.