Re: [Xen-devel] [PATCH v1 1/1] libxl/gentypes: add range init to array elements in json parsing

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Julien Grall writes ("Re: [Xen-devel] [PATCH v1 1/1] libxl/gentypes: add range 
init to array elements in json parsing"):
> I have made some comments regarding the patch in the original
> thread. While I am not a libxl expert, it would have been nice to
> address them or at least explain why they weren't addressed.

Yes.

> I will repeat them here for convenience.

Thanks.  It looks like our mails about this patch crossed.

> My knowledge of libxl is quite limited. But I don't think this is
> correct, you want to call init_fn whether this has been
> autogenerated or not.

Yes.

> I am also not entirely sure whether we should also cater the
> ty.init_val != None as well here.

We should.

I have a revised patch.  It makes no difference to the C output,
compared to Oleksandr's patch.  I assume we have no arrays of things
with an init_val...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel