Re: [Xen-devel] [PATCH v2] tools/ocaml: Fix build error with Arch Linux

[Wei Liu <wl@xxxxxxx>]

On Tue, Oct 29, 2019 at 12:38:35PM +0000, Wei Liu wrote:
> On Mon, 28 Oct 2019 at 16:38, Petre Pircalabu
> <ppircalabu@xxxxxxxxxxxxxxx> wrote:
> >
> > gcc (GCC) 9.2.0 complains:
> >
> > xentoollog_stubs.c: In function ‘stub_xtl_ocaml_vmessage’:
> > xentoollog_stubs.c:93:16: error: initialization discards ‘const’ qualifier 
> > from pointer target type [-Werror=discarded-qualifiers]
> >    93 |  value *func = caml_named_value(xtl->vmessage_cb) ;
> >       |                ^~~~~~~~~~~~~~~~
> >
> > This patch constifies the pointer returned by caml_named_value in order
> > to the accommodate newer versions of OCaml.
> > In OCaml >= 4.09 the return value pointer of caml_named_value is
> > declared const.
> >
> > https://github.com/ocaml/ocaml/commit/4f03a1467d29cf587df5a191830f1525506ee0e3
> >
> > Signed-off-by: Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>
> > Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
> 
> Acked-by: Wei Liu <wl@xxxxxxx>
> 
> I will wait a few days for Christian and David to chime in. If I don't
> hear back by Monday, I'm going to commit this patch -- this is pretty
> mechanical anyway.
> 

Andrew informed me OOB that Christian is away, so I have committed this
patch.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel