Re: [Xen-devel] [XEN PATCH 1/3] set default kernel from grubenv next_entry or saved_entry

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

YOUNG, MICHAEL A. writes ("[XEN PATCH 1/3] set default kernel from grubenv 
next_entry or saved_entry"):
> This patch reads the contents of a grubenv file if available, and
> uses the value of next_entry (in preference) or of saved_entry to
> set the default kernel if there is a matching title or if it is a
> number.  If either next_entry or saved_entry is set and neither is
> used then the default is set to 0.

Are you sure the grubenv file has a compatible enough syntax with the
grub.cfg file ?  I had a look at grub_split and AFIACT from the
confusing way it is expressed, it splits on the earliest of = ' ' '\t'
which I guess is right ...

Is it deliberate that your implementation strategy would honour
`next_entry' and `saved_entry' commands in grub.cfg ?

Are you sure it is correct that your implementation strategy would
honour `title' etc. if it occurred in grubenv ?  My reading of the
documentation is that grubenv may be less trusted.

Despite these misgivings, I think this patch is probably better than
nothing.

So:
  Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

But I think depending on the answer to my questions above we may want
a health warning of some kind in the release notes, or a followup.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel