[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v1] x86/altp2m: Add hypercall to create a new view and set sve bits
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- Date: Fri, 25 Oct 2019 14:36:05 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EnxbktykX0WWrv/HiqQa1vm+2TcYDB5nDUFmAlcSAZA=; b=la5NN/WNpDmgyejKJ95lOzH7PNaXRQmZr/IWYpd0m1UiHB5dPlBPmHh7IFfa+3XqAwjgvVm2tiwwwMp3DsbmT8NvCRPppXsl3uCeaffN2b6eik5iBBQQCztUPlQDVr6kIzHuKGMluHFh/tw0jIu1OZyZWph5e9hK2ZkYiCN8fe1pFkwq4krJVTkfAMf30Aj7nYw/VEBhSu30p7McOANTg/BMpYNHv7G0KOk2SNYIhWBK+aI5Z+p7cHmKKknPI+D7P3ZBV+kvLXs3s6HSJAKUTcJJPQHfb3uaa/Z2/oKXiZgcyDpCt+6R49Ntats1iyIOkhkVAb+9LEYEZGBcRXgoYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZur2ieWysxbGDyUAz4hNbyQ5BU6V0aEveSZuiE/EhCTrXxFAs0bdah3UpCjHJATJZANHEEeZqQoPQHs252eVgYsOyp5bdPQrw/dZfM73iv+3PXGIdbWFSt05gePKQDnJHG6+ne1YRv/T4bBMi0kEUueKdxaOL2COOKH7LMmLnuaoIzTv64Vpmiv9PQjriw5rCN7zFRnwb888tR22lv6bWkKIa1XXAeFCMvEpL1cyoRyZSPOxfQ8SsnFbzSPQSEj31K4RfucssbMx4zhwY4Z645Aqove0lj5qVH4tIA248VS5KTiSeladH9HfXfmwcS6cxRkKaGuMWAjE1L4PNiDYA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
- Cc: "kevin.tian@xxxxxxxxx" <kevin.tian@xxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jun.nakajima@xxxxxxxxx" <jun.nakajima@xxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 25 Oct 2019 14:36:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVYWYIdb/r2yKq9kGUPnrK2APIqqcaHHgAgAAZmgCATj09AP///F+AgANQk4A=
- Thread-topic: [Xen-devel] [PATCH v1] x86/altp2m: Add hypercall to create a new view and set sve bits
On 23.10.2019 14:58, Roger Pau Monné wrote:
> On Wed, Oct 23, 2019 at 09:11:54AM +0000, Alexandru Stefan ISAILA wrote:
>>
>>
>> On 03.09.2019 20:24, Tamas K Lengyel wrote:
>>> On Tue, Sep 3, 2019 at 9:53 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>>
>>>> On 02.09.2019 10:11, Alexandru Stefan ISAILA wrote:
>>>>> --- a/xen/include/public/hvm/hvm_op.h
>>>>> +++ b/xen/include/public/hvm/hvm_op.h
>>>>> @@ -244,6 +244,7 @@ struct xen_hvm_altp2m_view {
>>>>> /* Create view only: default access type
>>>>> * NOTE: currently ignored */
>>>>> uint16_t hvmmem_default_access; /* xenmem_access_t */
>>>>> + uint8_t set_sve; /* bool value */
>>>>> };
>>>>
>>>> This interface is, given the right configuration, available to
>>>> guests. Hence you can't simply add a field here. Just consider
>>>> what happens for an existing caller when there is random data
>>>> in the field you now assign a meaning.
>>>
>>> Perhaps instead of extending the HVMOP it would make more sense to
>>> just add a xl config option that defines the "default" sve bit for
>>> altp2m views in the domain?
>>>
>>
>> Adding a xl config option will not work for systems that do use xl.
>> There is a need that this will work in all cases.
>
> I assume that such option would be implemented using a DOMCTL, which
> can also be used by other toolstacks. I however have no idea whether
> this is a suitable interface or not for this feature.
>
I think that having a HVMOP_altp2m_get_suppress_ve_multi and letting the
caller provide the start gfn and the nr of pages to have the sve bits
set will provide a good solution for init an dfor further development.
I will go on this way for version 2 if everyone is ok with this.
Thanks,
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
