|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [xen-unstable-smoke test] 143118: trouble: blocked/broken/pass
flight 143118 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/143118/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 <job status> broken build-amd64 4 host-install(4) broken REGR. vs. 143111 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass version targeted for testing: xen 333d7412796e8fd485bfbb79180a520f7e08bc27 baseline version: xen 4f05a0c775871abd4b8147048f067c1cfe408645 Last test of basis 143111 2019-10-24 15:01:54 Z 0 days Testing same since 143118 2019-10-24 18:08:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD <anthony.perard@xxxxxxxxxx> Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Wei Liu <wl@xxxxxxx> jobs: build-arm64-xsm pass build-amd64 broken build-armhf pass build-amd64-libvirt blocked test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-amd64 broken broken-step build-amd64 host-install(4) Not pushing. ------------------------------------------------------------ commit 333d7412796e8fd485bfbb79180a520f7e08bc27 Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Wed Oct 23 13:55:54 2019 +0100 libxl: On ARM, reject future new passthrough modes too This is most pleasantly done by also changing the if to a switch. Suggested-by: Julien Grall <julien@xxxxxxx> CC: Julien Grall <julien@xxxxxxx> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> commit ad011ad08843f60f9ae17b9ae4aa5907674d72af Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Mon Oct 7 17:59:15 2019 +0100 libxl/xl: Overhaul passthrough setting logic LIBXL_PASSTHROUGH_UNKNOWN (aka "ENABLED" in an earlier uncommitted version of this code) is doing double duty. We actually need all of the following to be specifiable: * "default": enable PT iff we have devices to pass through specified in the initial config file. * "enabled" (and fail if the platform doesn't support it). * "disabled" (and reject future PT hotplug). * "share_pt"/"sync_pt": enable PT and set a specific PT mode. Defaulting and error checking should be done in libxl. So, we make several changes here. We introduce "enabled", and rename "unknown" to "default". We move all of the error checking and defaulting code from xl into libxl. Now, libxl__domain_config_setdefault has all of the necessary information to get this right. So we can do it all there. Choosing the specific mode is arch-specific. We can also arrange to have only one place each which calculates (i) whether passthrough needs to be enabled because pt devices were specified (ii) whether pt_share can be used (for each arch). xl now only has to parse the enum in the same way as it parses all other enums. This change fixes a regression from earlier 4.13-pre: until recent changes, passthrough was only enabled by default if passthrough devices were specified. We restore this behaviour. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx> CC: Julien Grall <julien@xxxxxxx> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx> CC: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> CC: Paul Durrant <pdurrant@xxxxxxxxx> CC: Jan Beulich <jbeulich@xxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> commit 95596f6ab18feb825006ef8f272041f1d94e6bd1 Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Fri Oct 11 17:16:44 2019 +0100 libxl: Move domain_create_info_setdefault earlier We need this before we start to figure out the passthrough mode. I have checked that nothing in libxl__domain_create_info_setdefault nor the two implementations of ..._arch_... accesses anything else, other than (i) the domain type (which this function is responsible for setting and nothing before it looks at) (ii) c_info->ssidref (which is defaulted by flask code near the top of libxl__domain_config_setdefault and not accessed afterwards). So no functional change. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> commit 5f135a65d2803f3636f52895cc811ec66576a8db Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Mon Oct 7 17:50:06 2019 +0100 libxl: create: setdefault: Move physinfo into config_setdefault No functional change. This will let us refer to it in code we are about to add to this function. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Acked-by: Wei Liu <wl@xxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> commit af5c475deed3b95a6a69cd4c0ef68132b487c079 Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Mon Oct 7 17:47:46 2019 +0100 libxl: create: setdefault: Make libxl_physinfo info[1] No functional change. This will let us make it into a pointer without textual change other than to the definition. While we are here, fix some style errors (missing { }). Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Acked-by: Wei Liu <wl@xxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> commit 5dedc18d64f46d7afb9eb6ce688791cc13f3e059 Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Fri Oct 4 15:36:59 2019 +0100 libxl: Remove/deprecate libxl_get_required_*_memory from the API These are now redundant because shadow_memkb and iommu_memkb are now defaulted automatically by libxl_domain_need_memory and libxl_domain_create etc. Callers should not now call these; instead, they should just let libxl take care of it. libxl_get_required_shadow_memory was introduced in f89f555827a6 "remove late (on-demand) construction of IOMMU page tables" We can freely remove it because it was never in any release. libxl_get_required_shadow_memory has been in libxl approximately forever. It should probably not have survived the creation of libxl_domain_create, but it seems the API awkwardnesses we see in recent commits prevented this. So we have to keep it. It remains functional but we can deprecate it. Hopefully we can get rid of it completely before we find the need to change the calculation to use additional information which its arguments do not currently supply. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> commit 67c82f437ed169258f89de2d925894f923c179cf Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Fri Oct 4 11:45:59 2019 +0100 libxl: Move shadow_memkb and iommu_memkb defaulting into libxl Defaulting is supposed to be done by libxl. So these calculations should be here in libxl. libxl__domain_config_setdefault has all the necessary information including the values of max_memkb and max_vcpus. The overall functional effect depends on the caller: For xl, no change. The code moves from xl to libxl. For callers who set one or both shadow_memkb and iommu_memkb (whether from libxl_get_required_shadow_memory or otherwise) before calling libxl_domain_need_memory (any version): the new code will leave their setting(s) unchanged. For callers who do not call libxl_domain_need_memory at all, and who fail to set one of these memory values: now they are both are properly set. The shadow and iommu memory to be properly accounted for as intended. For callers which call libxl_domain_need_memory and request the current API (4.13) or which track libxl, the default values are also now right and everything works as intended. For callers which call libxl_domain_need_memory, and request an old pre-4.13 libxl API, and which leave one of these memkb settings unset, we take special measures to preserve the old behaviour. This means that they don't get the additional iommu memory and are at risk of the domain running out of memory as a result of f89f555827a6 "remove late (on-demand) construction of IOMMU page tables". But this is no worse than the state just after f89f555827a6, which already broke such callers in that way. This is perhaps justifiable because of the API stability warning next to libxl_domain_need_memory. An alternative would be to drop the special-casing of these callers. That would cause a discrepancy between libxl_domain_need_memory and libxl_domain_create: the former would not include the iommu memory and the latter would. That seems worse, but it's debateable. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> commit a9af7cd17d72f27f04d824181dbb62887feb4211 Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Thu Oct 3 16:58:32 2019 +0100 libxl: libxl_domain_need_memory: Make it take a domain_config This should calculate the extra memory needed for shadow and iommu, the defaults for which depend on values in c_info. So we need this to have the complete domain config available. And the defaults should actually be updated and stored. So make it non-const. We provide the usual kind of compatibility function for callers expecting 4.12 and earlier. This function becomes responsible for the clone-and-modify of the b_info. No overall functional change for external libxl callers which use the API version system to request a particular API version. Other external libxl callers will need to update their calling code, and will then find that the new version of this function fills in most of the defaults in d_config. Because libxl__domain_config_setdefault doesn't quite do all of the defaults, that's only partial. For present purposes that doesn't matter because none of the missing settings are used by the memory calculations. It does mean we need to document in the API spec that the defaulting is only partial. This lack of functional change is despite the fact that numa_place_domain now no longer calls libxl__domain_build_info_setdefault (via libxl_domain_need_memory). That is OK because it's idempotent and numa_place_domain's one call site is libxl__build_pre which is called from libxl__domain_build which is called from domcreate_bootloader_done, well after the defaults are set by initiate_domain_create. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> commit 2541fcc34cd546e64a0cfc141c4f7b84fa87e685 Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Thu Oct 3 17:31:15 2019 +0100 libxl: libxl__domain_config_setdefault: New function Break out this into a new function. We are going to want to call it from a new call site. Unfortunately not all of the defaults can be moved into the new function without changing the order in which things are done. That does not seem wise at this stage of the release. The effect is that additional calls to libxl__domain_config_setdefault (which are going to be introduced) do not quite set everything. But they will do what is needed. After Xen 4.13 is done, we should move those settings into the right order. No functional change. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> commit 3f21bd497747fbfe6e548a3c50b55dfe21a1eefb Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Thu Oct 3 17:06:43 2019 +0100 xl: Pass libxl_domain_config to freemem(), instead of b_info We are going to change the libxl API in a moment and this change will make it simpler. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> commit c3999835df2d9917cf4b50be80be9a6358b1219d Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Fri Oct 4 15:30:22 2019 +0100 libxl: Offer API versions 0x040700 and 0x040800 According to git log -G: 0x040700 was introduced in 304400459ef0 (aka 4.7.0-rc1~481) "tools/libxl: rename remus device to checkpoint device" 0x040800 was introduced in 57f8b13c7240 (aka 4.8.0-rc1~437) "libxl: memory size in kb requires 64 bit variable" It is surprising that no-one noticed this. Anyway, in the meantime, we should fix it. Backporting this is probably a good idea: it won't change the behaviour for existing callers but it will avoid errors for some older correct uses. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Release-acked-by: Juergen Gross <jgross@xxxxxxxx> (qemu changes not included) _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |